Skip to content

Solve deprecated _chunkedClient.flush() #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

Solve deprecated _chunkedClient.flush() #11974

merged 2 commits into from
Nov 3, 2025
+1 −1

Conversation

@BCsabaEngine
Copy link
Contributor

@BCsabaEngine BCsabaEngine commented Nov 2, 2025 •
edited by P-R-O-C-H-Y
Loading

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Related links

Please provide links to related issue, PRs etc.

...
Compiling .pio/build/default/lib7e0/WiFi/WiFiGeneric.cpp.o
Compiling .pio/build/default/lib7e0/WiFi/WiFiMulti.cpp.o
/Users/xxxxxxxx/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp: In member function 'void WebServer::chunkResponseEnd()':
/Users/xxxxxxxx/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp:616:23: warning: 'virtual void NetworkClient::flush()' is deprecated: Use clear() instead. [-Wdeprecated-declarations]
  616 |   _chunkedClient.flush();
      |   ~~~~~~~~~~~~~~~~~~~~^~
In file included from /Users/balazscsaba/.platformio/packages/framework-arduinoespressif32/libraries/Network/src/NetworkServer.h:23,
                 from /Users/balazscsaba/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp:28:
/Users/xxxxxxxx/.platformio/packages/framework-arduinoespressif32/libraries/Network/src/NetworkClient.h:61:8: note: declared here
   61 |   void flush();  // Print::flush tx
      |        ^~~~~
Compiling .pio/build/default/lib7e0/WiFi/WiFiSTA.cpp.o
...

Closes #11976

@BCsabaEngine BCsabaEngine requested a review from a team as a code owner November 2, 2025 13:20
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello BCsabaEngine, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 965d9e9

@lucasssvaz lucasssvaz requested a review from me-no-dev November 2, 2025 13:55
@SuGlider SuGlider self-requested a review November 3, 2025 07:09
SuGlider
SuGlider approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Test Results

 76 files   76 suites   16m 13s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 965d9e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/DNSServer/examples/CaptivePortal00000000000000
libraries/HTTPUpdateServer/examples/WebUpdater00000000000000
libraries/Update/examples/HTTP_Server_AES_OTA_Update00000000000000
libraries/Update/examples/OTAWebUpdater00000000000000
libraries/WebServer/examples/AdvancedWebServer00000000000000
libraries/WebServer/examples/ChunkWriting00000000000000
libraries/WebServer/examples/FSBrowser00000000000000
libraries/WebServer/examples/Filters00000000000000
libraries/WebServer/examples/HelloServer00000000000000
libraries/WebServer/examples/HttpAdvancedAuth00000000000000
libraries/WebServer/examples/HttpAuthCallback00000000000000
libraries/WebServer/examples/HttpAuthCallbackInline00000000000000
libraries/WebServer/examples/HttpBasicAuth00000000000000
libraries/WebServer/examples/HttpBasicAuthSHA100000000000000
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken00000000000000
libraries/WebServer/examples/Middleware00--0000000000
libraries/WebServer/examples/MultiHomedServers00000000000000
libraries/WebServer/examples/PathArgServer00000000000000
libraries/WebServer/examples/SDWebServer00000000000000
libraries/WebServer/examples/SimpleAuthentification00000000000000
libraries/WebServer/examples/UploadHugeFile00000000000000
libraries/WebServer/examples/WebServer00000000000000
libraries/WebServer/examples/WebUpdate00000000000000

@me-no-dev me-no-dev merged commit cbd49cf into espressif:master Nov 3, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compilation Warning: Deprecated 'flush()' method used in WebServer.cpp

5 participants

@BCsabaEngine @CLAassistant @me-no-dev @SuGlider @P-R-O-C-H-Y